Closed Bug 1882480 Opened 1 year ago Closed 8 months ago

[DE][bauhaus.info] Form autofill/preview/clear aren't applied on all the eligible fields

Categories

(Toolkit :: Form Autofill, task, P3)

Firefox 125
Desktop
macOS
task

Tracking

()

VERIFIED FIXED
133 Branch
Tracking Status
firefox123 --- disabled
firefox124 --- disabled
firefox125 --- disabled
firefox133 --- verified
firefox134 --- verified

People

(Reporter: hyacoub, Assigned: enndeakin)

References

(Blocks 1 open bug, Regressed 1 open bug, )

Details

(Whiteboard: [fxcm-addr-compatibility] )

Attachments

(3 files)

Found in

  • Firefox Nightly 125.0a1

Affected versions

  • Firefox Nightly 125.0a1

Tested platforms

  • Affected platforms: macOS 11.6

Preconditions

  • Install DE Firefox build
  • Use DE VPN
  • browser.search.region = DE
  • extensions.formautofill.addresses.experiments.enabled - true
  • extensions.formautofill.addresses.supportedCountries = DE
  • extensions.formautofill.addresses.capture.requiredFields = empty

Steps to reproduce

  1. Reach the address form on https://www.bauhaus.info
  2. Click on "Name" field
  3. Select any of the options for the dropdown
  4. Right click on any of the fields and choose "Clear autofill form"
  5. Repeat steps from above for the rest of the fields

Expected result

  • Form autofill/preview/clear should be applied on eligible fields.

Actual result

  • Form autofill/preview/clear are only applied on the selected field.

Regression range

  • N/A

Additional notes

  • Not reproducible on Chrome.
Attached file bauhaus.html
No longer depends on: 1882300
Priority: -- → P3

The fields on this site are being detected incorrectly. There is a 'company tax number' just before the name that is being detected as a credit card number and then pulling in the name fields as part of a credit card. Deleting this field makes the name and street fill in correctly, but the remaining fields do not get filled in.

The email field seems to autofill correctly, but the autocomplete dropdown seems to be as if it is a password field.

Whiteboard: [fxcm-addr-compatibility]

I investigated this further:

  • the company tax number is being treated as a credit card number, causing the field matching algorithm to think that there are credit card related fields and modify the name fields to be credit card fields.

  • the form has separate street and house number fields. The street matches correctly, but the house number doesn't match any fields. This causes _parseStreetAddressFields to modify the next field (Adresszusatz) to be an address-line1 rather than an address-line2. This causes a section split so the autofill doesn't work for the remaining fields

  • Bug 1882842 should fix the first issue.

  • For the second issue, _parseStreetAddressFields should be modified to handle this case.

Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e91e12c06e4 add support for recognizing german style addresses where the street name appears first and the number appears after, this allows form fill into separate street and house number fields, r=credential-management-reviewers,dimi
Regressions: 1925068
Regressions: 1925069
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch

Verified as Fixed on MacOS 14, Windows 11 and Ubuntu 22.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: